-
Notifications
You must be signed in to change notification settings - Fork 36
fix(core): Update async-graphql
, axum
and tonic
(#6901)
#6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Update async-graphql
, axum
and tonic
(#6901)
#6969
Conversation
Closes #6886 - Updated `async-graphql` to the latest commit with the CI ✅ - Updated `axum` to 0.8 - Updated `tonic` to 0.13 - Updated `tonic-rustls` to 0.2 - Removed the `{` -> `:` path patcher as `{}` is the correct syntax in `axum` `>0.8` - Moved from `/:` to `/{x}` syntax in axum endpoints - Updated some tests - Replaced `tonic::body::BoxBody` with `tonic::body::Body` - Removed the usage of `async_trait` in axum in impls of `FromRequest` and `FromRequestParts` due to the recent stabilization of `async fn` in traits (my guess tbh) - Changed from `Option` to `Result` a usage of `ConnectInfo` as that seems to be way it works now (tokio-rs/axum#3245 (comment)) This was necessary as `async-graphql` recently merged a fix for #6886, but to use it we also need to update `tonic` and therefore `axum` and `tonic-rustls`. Also, better to have more up to date deps if that means easier to fix other issues in the future 
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated after #6989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🫡
a8d62bb
into
releases/iota-v1.2.0-release
Description of change
This patch introduces the necessary changes to restore
graphiql
endpoints.async-graphql
to7.0.17
axum
to0.8
tonic
to0.13
tonic-rustls
to0.2
Type of change
Release Notes