Skip to content

fix(core): Update async-graphql, axum and tonic (#6901) #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kodemartin
Copy link
Contributor

@kodemartin kodemartin commented May 22, 2025

Description of change

This patch introduces the necessary changes to restore graphiql endpoints.

  • Updated async-graphql to 7.0.17
  • Updated axum to 0.8
  • Updated tonic to 0.13
  • Updated tonic-rustls to 0.2
  • Refactored accordingly the codebase

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Release Notes

  • GraphQL: Fix graphiql web interface

Closes #6886

- Updated `async-graphql` to the latest commit with the CI ✅ 
- Updated `axum` to 0.8
- Updated `tonic` to 0.13
- Updated `tonic-rustls` to 0.2
- Removed the `{` -> `:` path patcher as `{}` is the correct syntax in
`axum` `>0.8`
- Moved from `/:` to `/{x}` syntax in axum endpoints
- Updated some tests
- Replaced `tonic::body::BoxBody` with `tonic::body::Body` 
- Removed the usage of `async_trait` in axum in impls of `FromRequest`
and `FromRequestParts` due to the recent stabilization of `async fn` in
traits (my guess tbh)
- Changed from `Option` to `Result` a usage of `ConnectInfo` as that
seems to be way it works now
(tokio-rs/axum#3245 (comment))


This was necessary as `async-graphql` recently merged a fix for #6886,
but to use it we also need to update `tonic` and therefore `axum` and
`tonic-rustls`. Also, better to have more up to date deps if that means
easier to fix other issues in the future


![image](https://github.com/user-attachments/assets/4050f2f0-1d8f-4b14-86b1-2a660aeb2061)
@kodemartin kodemartin requested review from a team as code owners May 22, 2025 12:24
Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 2:45pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 2:45pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 2:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 26, 2025 2:45pm

@kodemartin kodemartin added this to the v1.2.x - protocol v8 milestone May 22, 2025
@kodemartin kodemartin requested a review from alexsporn May 22, 2025 12:24
@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels May 22, 2025
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated after #6989

Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✨

Closes #6914

Uses the latest release of `async-graphql` which now also contains the
graphiql fix

More info: #6901
@kodemartin kodemartin requested a review from a team as a code owner May 26, 2025 14:34
@github-actions github-actions bot added the ts-sdk Issues related to the TS SDK label May 26, 2025
Copy link
Contributor

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🫡

@kodemartin kodemartin merged commit a8d62bb into releases/iota-v1.2.0-release May 27, 2025
55 of 56 checks passed
@kodemartin kodemartin deleted the infra/fix-react-async-graphql branch May 27, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. ts-sdk Issues related to the TS SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants